clang_delta: Use real timeout for old&new passes #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old ClangBinarySearchPass class used to hardcode the 10-second timeout, which was insufficient for big inputs and led to a significant slowdown of the reduction as this heuristic didn't work at all. The new ClangHintsPass didn't have the timeout logic at all, which would result in hanging C-Vise if building Clang AST hangs. Fix both places to use the --timeout command-line parameter value.
emaxx-google
force-pushed
the
hint-clang-timeout
branch
from
9fb8ff7 to
73b263c
Compare
|
Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old ClangBinarySearchPass class used to hardcode the 10-second timeout, which was insufficient for big inputs and led to a significant slowdown of the reduction as this heuristic didn't work at all. The new ClangHintsPass didn't have the timeout logic at all, which would result in hanging C-Vise if building Clang AST hangs.
Fix both places to use the --timeout command-line parameter value.