hints: Fix 't' incorrect place for Blank pass and in Schema #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hint type property should be specified on the hint object, not on the patch. This was incorrectly documented in the Schema and incorrectly used in the Blank pass. Fix both places and add tests with strict sanity checks.
emaxx-google
force-pushed
the
hint-blank-fix-t-location
branch
from
bbb8cbe to
4e5f9f1
Compare
|
Also came up with another regression test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hint type property should be specified on the hint object, not on the patch. This was incorrectly documented in the Schema and incorrectly used in the Blank pass.
Fix both places and add tests with strict sanity checks.