MDL-72397 qbank_managecategories: UI enhancement

This implementation will introduce a new user interface for
"qbank_managecategories" plugin which will allow user to drag and drop.
Having this plugin will give users the flexibility of reordering, adding
or editing
categories from the qbank_managecategories view.

Co-authored-by: Mark Johnson <[email protected]>
Co-authored-by: Luca Bösch <[email protected]>

mod/quiz/classes/question/bank/filter/custom_category_condition_helper.php

@@ -31,7 +31,7 @@
  */
 class custom_category_condition_helper extends \qbank_managecategories\helper {
 
-    public static function question_category_options(array $contexts, bool $top = false, int $currentcat = 0,
+    public static function question_category_options(array $contexts, bool $includetop = false, int $currentcat = 0,
         bool $popupform = false, int $nochildrenof = -1,
         bool $escapecontextnames = true): array {
         global $CFG;
@@ -41,9 +41,9 @@ public static function question_category_options(array $contexts, bool $top = fa
         }
         $contextslist = join(', ', $pcontexts);
 
-        $categories = self::get_categories_for_contexts($contextslist, 'parent, sortorder, name ASC', $top);
+        $categories = self::get_categories_for_contexts($contextslist, 'parent, sortorder, name ASC', $includetop);
 
-        if ($top) {
+        if ($includetop) {
             $categories = self::question_fix_top_names($categories);
         }
 

mod/quiz/tests/behat/editing_add.feature

@@ -99,22 +99,12 @@ Feature: Edit quiz page - adding things
       in various categories and add them to the question bank.
 
     # Create a couple of sub categories.
-    When I am on the "Course 1" "core_question > course question categories" page
-    Then I should see "Add category"
-    And I follow "Add category"
-    Then I set the field "Parent category" to "Default for C1"
-    And I set the field "Name" to "Subcat 1"
-    And I set the field "Category info" to "This is sub category 1"
-    And I press "id_submitbutton"
-    And I should see "Subcat 1"
-
-    And I follow "Add category"
-    Then I set the field "Parent category" to "Default for C1"
-    And I set the field "Name" to "Subcat 2"
-    And I set the field "Category info" to "This is sub category 2"
-    And I press "id_submitbutton"
-    And I should see "Subcat 2"
-
+    Given the following "question categories" exist:
+      | contextlevel | reference | questioncategory | name           |
+      | Course       | C1        | Default for C1   | Subcat 1       |
+      | Course       | C1        | Default for C1   | Subcat 2       |
+    When I am on "Course 1" course homepage
+    And I navigate to "Question bank" in current page administration
     And I select "Questions" from the "Question bank tertiary navigation" singleselect
     And I should see "Question bank"
 

mod/quiz/tests/behat/random_question.feature

@@ -62,11 +62,13 @@ Feature: Moving a question to another category should not affect random question
     And I press "Add random question"
     And I should see "Random question based on filter condition" on quiz page "1"
     And I am on the "Course 1" "core_question > course question categories" page
-    And I click on "Edit this category" "link" in the "Used category" "list_item"
+    And I open the action menu in "Used category" "list_item"
+    And I choose "Edit" in the open action menu
     And I set the following fields to these values:
       | Name            | Used category new |
       | Category info   | I was edited      |
-    And I press "Save changes"
+    And I press "Edit category"
+    And I set the field "Show descriptions" to "1"
     Then I should see "Used category new"
     And I should see "I was edited" in the "Used category new" "list_item"
     And I am on the "Quiz 1" "mod_quiz > Edit" page