Skip to content

Commit

Permalink
MDL-75610 theme: Allow the activity title in Boost theme's secure layout
Browse files Browse the repository at this point in the history
  • Loading branch information
marxjohnson committed Nov 13, 2024
1 parent 3af9e0c commit 9b4f85c
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 1 deletion.
19 changes: 19 additions & 0 deletions .upgradenotes/MDL-75610-2024111313224921.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
issueNumber: MDL-75610
notes:
core:
- message: >
`\core\output\activity_header` now uses the `is_title_allowed()` method
when setting the title in the constructor.
This method has been improved to give priority to the 'notitle' option
in the theme config for the current page layout, over the top-level
option in the theme.
For example, the Boost theme sets
`$THEME->activityheaderconfig['notitle'] = true;` by default, but in its
`secure` pagelayout, it has `'notitle' = false`.
This prevents display of the title in all layouts except `secure`.
type: improved
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,5 @@ Feature: View the activity header when Safe Exam Browser is required
Scenario: Quiz description is displayed when Safe Exam Browser is required
When I am on the "Test quiz name" "quiz activity" page logged in as student1
Then I should see "Launch Safe Exam Browser"
And "Test quiz name" "heading" should exist
And I should see "Test quiz description"
7 changes: 6 additions & 1 deletion theme/boost/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,12 @@
'secure' => array(
'file' => 'secure.php',
'regions' => array('side-pre'),
'defaultregion' => 'side-pre'
'defaultregion' => 'side-pre',
'options' => [
'activityheader' => [
'notitle' => false,
],
],
)
];

Expand Down

0 comments on commit 9b4f85c

Please sign in to comment.