-
Notifications
You must be signed in to change notification settings - Fork 286
Enhance DocC-compatible inline docs for future documentation (Issue #866) #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@RintaroYamada Thanks for starting this. I've quickly looked over this PR while on my phone, so if I misunderstood something, please let me know. BackgroundThe documentation in the DocC comments does not appear to have been included in the generated Markdown file, which is expected because, IIUC, the plugin reads the documentation from SAP constructs (like I think the DocC confusion might stem from the plugin using DocC formatted input from the aforementioned SAP constructs, not DocC formatted input from DocC comments. The documentation should also be removed from TL;DRThus, can you move the docs from the DocC comments into SAP constructs (after researching how the various SAP construct options for generating docs)? Instead of leaving the commit where the docs are in the comments in the PR branch, please rebase your new version on main, so the docs go straight into the SAP constructs, rather than detouring through the DocC comments. Thanks again. |
@rgoldberg |
@RintaroYamada Thanks for the heads up. This open PR for SAP from someone else, not from me, is to improve the Markdown generation plugin (it might eventually also update the man page generation plugin). You might want to see if it will change what you'll want to do for mas. A completely separate question: what are you using to work on mas? i.e.: what version of macOS, Xcode, Xcode Command-Line Tools, and anything else that might be relevant are you using? Are you able to build mas in Xcode? I was previously able to build older versions of mas in Xcode 14.2 on macOS 12.7.6 on Intel, but neither those same versions of mas, nor newer versions of mas, will build for me in Xcode 16.4 on macOS 15.5 on an M4 (nor in Xcode 16.3 before I upgraded to 16.4). Obviously, |
Hi @rgoldberg, Thanks for your message. Here's my current environment and build status: Environment Information: macOS: I was able to successfully build mas using swift build on this setup. The build output included a couple of minor warnings from dependencies (Quick and Nimble) about .xcprivacy files not being declared as resources: warning: 'quick': found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target Build complete! (6.89s) |
@RintaroYamada Thanks for the info. Are you building from the command line using Or are you building inside of Xcode itself? (Using the build action or any of its derivatives) Have you ever been able to debug mas in Xcode? I'm able to build from the command line using Thanks again. |
Hi @rgoldberg, Thanks for the follow-up. To clarify: I’ve been building mas using swift build directly from the command line (in the root directory). Let me know what would be most helpful next! |
@RintaroYamada If you're building from the command line, it's easiest to use Getting debugging to work in Xcode 16.4 would be very useful. Maybe it will work immediately for you, or maybe you'd run into the same issue that I do or another issue when building to debug in Xcode 16.4. Please let me know what happens when you try that. |
Summary
This PR enhances inline documentation within mas commands using DocC-compatible comments (
///
,CommandConfiguration.abstract
,@Argument(help:)
, etc.).The goal is to lay the foundation for proper DocC and manpage generation in the future.
Context
generate-docc-reference
, and confirmed it works..docc
markdown files, detailed documentation does not yet appear in preview..md
files undermas.docc
(e.g.,install.md
,list.md
) to generate a full-featured DocC website.Notes
Thank you for maintaining this project!