design 스펙에 맞게 프롬프트 및 zod 수정 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 4238234 Author: Choi-JY1107 <[email protected]> Date: Sun Jun 29 03:09:37 2025 +0900 refactor: prompt는 다른 폴더로 분리 commit 5562f4b Author: Choi-JY1107 <[email protected]> Date: Sun Jun 29 02:30:05 2025 +0900 refactor: 매직 넘버는 constant에서 관리하도록 수정 commit bf41742 Author: Choi-JY1107 <[email protected]> Date: Sun Jun 29 02:21:24 2025 +0900 fix: title에 대한 제한 조건을 한국말로 변경 commit c240973 Author: Choi-JY1107 <[email protected]> Date: Sun Jun 29 01:31:27 2025 +0900 refactor: zod를 통해 design 요구사항 충족
chsjen492
requested changes
Jun 28, 2025
src/ai/prompt/system-prompt.ts
Outdated
Comment on lines
5
to
6
| 2. Based on the title, generate a funny Korean nickname that matches the outfit’s vibe. Nicknames should be up to 7 characters, including spaces, in Korean. | ||
| 3. Based on the title, generate 3 to 4 witty hashtags in Korean that exaggerate or joke about the outfit. Together, the hashtags must be up to 20 characters, including spaces and #, in Korean. |
There was a problem hiding this comment.
해시태그랑 닉네임은 한글로 글자수 제한을 선언해주지 않아도 괜찮나요?
src/ai/prompt/system-prompt.ts
Outdated
| 1. "title"은 한국어로 작성하며, 25자 이상 33자 이하로 작성합니다. 제목은 유머러스하고 풍자적인 느낌을 주어야 합니다. | ||
| 2. Based on the title, generate a funny Korean nickname that matches the outfit’s vibe. Nicknames should be up to 7 characters, including spaces, in Korean. | ||
| 3. Based on the title, generate 3 to 4 witty hashtags in Korean that exaggerate or joke about the outfit. Together, the hashtags must be up to 20 characters, including spaces and #, in Korean. | ||
| 4. Based on the title, assign a "totalScore" (1 to 100) Please grade the user's fashion with strict eyes |
There was a problem hiding this comment.
점수 매기는 부분 3단계에 해당되는 부분이라 The higher the spice level, the more strict it is 이걸로 바꾸는게 나을 것 같아요
src/ai/prompt/system-prompt.ts
Outdated
Comment on lines
44
to
46
| You are OOTD (Outfit of the Day) Roster, a sarcastic and witty fashion reviewer. | ||
| Users will provide OOTD photos. Please evaluate the user's clothes with an objective gaze.` + | ||
| COMMON_RULE_SYSTEM_PROMPT.trim() + |
There was a problem hiding this comment.
1이랑 동일한 평가가 들어갔어요
You are "Gongjeong," a fictional character from the parody show "Project Lost Way," who always evaluates fashion with an objective perspective, earning the trust and relatability of the audience. Your mission is to deliver evaluations that avoid personal or identity-based insults, but instead use slight exaggeration and sarcasm to critique the user's fashion.
You focus solely on the style, outfit choices, and fashion decisions—not the person’s appearance. Your opinions are expressed in an entertaining and humorous way, but always remain within the boundaries of satire and fashion-centered entertainment.
이걸로 바꿔주세용
src/ai/prompt/system-prompt.ts
Outdated
Comment on lines
30
to
32
| You are OOTD (Outfit of the Day) Roster, a sarcastic and witty fashion reviewer. | ||
| Users will provide OOTD photos. Please evaluate the user's clothes with an objective gaze.` + | ||
| COMMON_RULE_SYSTEM_PROMPT.trim() + |
There was a problem hiding this comment.
You are OOTD (Outfit of the Day) Reviewer, a friendly and complimentary fashion reviewer.
The user will provide OOTD photos. Please give a lot of compliments about the user's outfit
1단계는 요거입니당
src/ai/prompt/system-prompt.ts
Outdated
Comment on lines
34
to
40
| <<💡 Output Title Examples>> | ||
| "상의랑 하의가 서로 처음 만났나? 패션 세계의 블라인드 미팅!" | ||
| "전체적인 모습이 다크 모드인가요? 패션까지 밤하늘처럼 깜깜합니다!" | ||
| "패션의 밤은 길고, 그의 바지는 더 길다!" | ||
| "저 바지, 줄다리기 하다 끊겨서 입은 거 아니죠?" | ||
| "어디 여행 갔다 오셨나요...90년대로?"` + | ||
| COMMON_RESPONSE_SYSTEM_PROMPT.trim(); |
| nickname: z.string().describe('funny nickname (Korean)'), | ||
| title: z | ||
| .string() | ||
| .min(OOTD_TITLE_MIN, { message: 'title must be at least 25 characters' }) |
There was a problem hiding this comment.
최소 제한은 20자로만 둬도 되지 않을까요?? 최소 최대의 차이가 크지 않아서..
- title을 최소 글자수를 20자로 수정 - 프롬프트 1과 2가 같게 들어간 점 수정 - 유효성 검사 시, nickname, hashtag도 같이 검사하도록 수정
감사합니다. |
J-Hoplin
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
resolve #69
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)
리팩토링했습니다..
📚 참고할만한 자료(선택)