Skip to content

Refact/#64 onboarding #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 10, 2025
Merged

Refact/#64 onboarding #67

merged 13 commits into from
Jul 10, 2025

Conversation

SijongKim93
Copy link
Collaborator

@SijongKim93 SijongKim93 commented Jul 9, 2025 •
edited by github-actions bot
Loading

πŸ“„ μž‘μ—… λ‚΄μš©

  • Onboarding 이전에 κ΅¬ν˜„ν•΄λ‘” 방식 λͺ¨λ“ˆν™” μˆ˜μ • λ°”νƒ•μœΌλ‘œ λ§ˆμ΄κ·Έλ ˆμ΄μ…˜ 진행
  • Google Login μ„œλ²„ μ—°κ²° 둜직 μˆ˜μ • ( 전달 토큰 λ³€κ²½ )

πŸ’» μ£Όμš” μ½”λ“œ μ„€λͺ…

기쑴에 access Token 을 μ „λ‹¬ν•˜λŠ” κ³Όμ •μ—μ„œ -> authorization Code μ „λ‹¬ν•˜λŠ” λ°©μ‹μœΌλ‘œ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

κ·Έ μ™Έ μ˜¨λ³΄λ”© 전체 둜직 λ§ˆμ΄κ·Έλ ˆμ΄μ…˜ ν–ˆμŠ΅λ‹ˆλ‹€.

βœ”οΈ CI Completed

  • βœ… Lint: Completed
  • βœ… Build: Completed

βœ”οΈ CI Completed

  • βœ… Lint: Completed
  • βœ… Build: Completed

@SijongKim93 SijongKim93 requested review from hooni0918 and k-nh July 9, 2025 15:31
@SijongKim93 SijongKim93 self-assigned this Jul 9, 2025
@SijongKim93 SijongKim93 added refactor κΈ°μ‘΄ μ½”λ“œλ₯Ό λ¦¬νŒ©ν† λ§ν•˜κ±°λ‚˜ μˆ˜μ •ν•˜λŠ” λ“± μ‚¬μš© sijong λ‚˜λŠ” μ‹œμ’… labels Jul 9, 2025
hooni0918
hooni0918 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@hooni0918 hooni0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λŒ€κ·œλͺ¨ νŒ¨μΉ˜μ—¬μ„œ κ³€λž€ν•˜μ…§μ„ν…λ° κ³ μƒν•˜μ…§μŠ΅λ‹ˆλ‹€. μ™„μ„±ν•˜κ³  λ¦¬νŒ©ν† λ§κΉŒμ§€ 달렀달렀~
스크란샷 2025-07-10 α„‹α…©α„Œα…₯ᆫ 1 43 36

Projects/Onboarding/OnboardingData/Sources/DTO/TagReqeustDTO.swift Outdated
@@ -0,0 +1,23 @@
//
// TagReqeustDTO.swift
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ˜€νƒ€λ‹·

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ˜€λ§ˆμ΄κ°“λšœ

Projects/Onboarding/OnboardingFeature/Sources/Store/OnboardingModel.swift Outdated

case saveLeaveStarted
case saveLeaveSucceeded
case saveLeaveSuccaFailed(Error)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 μ˜€νƒ€μΈκ²ƒκ°™μ•„μš”

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ˜€λ§ˆμ΄κ°“λšœ νœ΄λ¨Όμ—λŸ¬..

Projects/Onboarding/OnboardingFeature/Sources/Store/OnboardingStore.swift Outdated
Comment on lines 70 to 74
DispatchQueue.main.async {
self.state.nickname = filteredNickname
self.state.nicknameError = result.errorMessage
self.updateStepValidation()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„μ£Ό μ‚¬μ†Œν•˜κΈ΄ ν•œλ° ν¬λ¦¬ν‹°μ»¬ν•˜μ§€λŠ” μ•Šμ€ λ¬Έμ œκ°€ μ—¬λŸ¬ κ³³μ—μ„œ state μˆ˜μ • μ‹œ race condition이 λ°œμƒν• μˆ˜λ„ μžˆμ„κ²ƒκ°™μ•„μš”
μ•„μ–˜ updateNicknameλ©”μ„œλ“œμ— @mainactor을 λΆ™μ΄κ±°λ‚˜ λͺ¨λ“  state μ—…λ°μ΄νŠΈλ₯Ό reducerλ₯Ό ν†΅ν•΄μ„œλ§Œ μ§„ν–‰λ˜κ²Œ μˆ˜μ •ν• μˆ˜ μžˆμ„κ²ƒκ°™μŠ΅λ‹ˆλ‹€

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 λΆ€λΆ„ μ²΄ν¬ν•΄μ„œ μˆ˜μ •ν•˜κ² μŠ΅λ‹ˆλ‹€ :)

@SijongKim93 SijongKim93 force-pushed the refact/#64-Onboarding branch from 4f3b65f to dd38d2e Compare July 10, 2025 07:34
@SijongKim93 SijongKim93 merged commit bd87557 into develop Jul 10, 2025
1 check passed
@hooni0918 hooni0918 deleted the refact/#64-Onboarding branch July 11, 2025 00:00
k-nh added a commit that referenced this pull request Jul 11, 2025
@k-nh
feat/#67-곡톡 DS ν…μŠ€νŠΈ ν•„λ“œ ν‚€λ³΄λ“œ νƒ€μž… μ„€μ • 적용
0b7e75b
k-nh added a commit that referenced this pull request Jul 11, 2025
@k-nh
feat/#67-곡톡 DS λ²„νŠΌ μ‚¬μš©κ°€λŠ₯ν•œλ„ˆλΉ„ μ±„μš°κΈ° μ˜΅μ…˜ 적용
42a5c07
k-nh added a commit that referenced this pull request Jul 11, 2025
@k-nh
feat/#67-νœ΄κ°€ κ΅½κΈ° ν”Œλ‘œμš° UI 적용
e855cce
k-nh added a commit that referenced this pull request Jul 12, 2025
@k-nh
feat/#67-λ¦¬μ†ŒμŠ€ λ³€κ²½ 사항 적용
4e44ad7
k-nh added a commit that referenced this pull request Jul 12, 2025
@k-nh
feat/#67-νœ΄κ°€ μΆ”μ²œ 식빡뷰 κ΅¬ν˜„
b71b35f
k-nh added a commit that referenced this pull request Jul 12, 2025
@k-nh
feat/#67-ν…μŠ€νŠΈ μˆ˜μ • 사항 반영, 파일 정리
7bbb470
k-nh added a commit that referenced this pull request Jul 12, 2025
@k-nh
feat/#67-ν…μŠ€νŠΈ μˆ˜μ • 사항 반영, 파일 정리
2647316
k-nh added a commit that referenced this pull request Jul 12, 2025
@k-nh
feat/#67-λ‚ μ§œ μœ νš¨μ„± 검사 둜직 뢄리
72a6e72
SijongKim93 added a commit that referenced this pull request Jul 13, 2025
@SijongKim93
Merge pull request #67 from mash-up-kr/refact/#64-Onboarding
0f64797 
Refact/#64 onboarding
SijongKim93 pushed a commit that referenced this pull request Jul 13, 2025
@k-nh
feat/#67-곡톡 DS ν…μŠ€νŠΈ ν•„λ“œ ν‚€λ³΄λ“œ νƒ€μž… μ„€μ • 적용
519f54a
SijongKim93 pushed a commit that referenced this pull request Jul 13, 2025
@k-nh
feat/#67-곡톡 DS λ²„νŠΌ μ‚¬μš©κ°€λŠ₯ν•œλ„ˆλΉ„ μ±„μš°κΈ° μ˜΅μ…˜ 적용
8ecc798
SijongKim93 pushed a commit that referenced this pull request Jul 13, 2025
@k-nh
feat/#67-νœ΄κ°€ κ΅½κΈ° ν”Œλ‘œμš° UI 적용
f120a03
SijongKim93 pushed a commit that referenced this pull request Jul 13, 2025
@k-nh
feat/#67-λ¦¬μ†ŒμŠ€ λ³€κ²½ 사항 적용
b3853c4
SijongKim93 pushed a commit that referenced this pull request Jul 13, 2025
@k-nh
feat/#67-νœ΄κ°€ μΆ”μ²œ 식빡뷰 κ΅¬ν˜„
30fb973
SijongKim93 pushed a commit that referenced this pull request Jul 13, 2025
@k-nh
feat/#67-ν…μŠ€νŠΈ μˆ˜μ • 사항 반영, 파일 정리
45af89e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hooni0918 hooni0918 hooni0918 approved these changes

@k-nh k-nh Awaiting requested review from k-nh

Assignees

@SijongKim93 SijongKim93

Labels
refactor κΈ°μ‘΄ μ½”λ“œλ₯Ό λ¦¬νŒ©ν† λ§ν•˜κ±°λ‚˜ μˆ˜μ •ν•˜λŠ” λ“± μ‚¬μš© sijong λ‚˜λŠ” μ‹œμ’…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SijongKim93 @hooni0918