[Feat/#69] Recommend Vacation 구현 #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hooni0918
requested review from
hooni0918 and
SijongKim93
and removed request for
hooni0918
hooni0918
approved these changes
Jul 12, 2025
| } | ||
| } | ||
|
|
||
| private func validateInput(_ newValue: String) { |
There was a problem hiding this comment.
단순의견) MVI 구조가 잡혀있는만큼 해당 로직이 비즈니스 로직이라 생각되는데 View가 아닌 VacationBakingStore로 옮기는것은 어떻까요?
k-nh
force-pushed
the
feat/#69-recoVacation
branch
from
72a6e72 to
8c617f3
Compare
SijongKim93
pushed a commit
that referenced
this pull request
Jul 13, 2025
[Feat/#69] Recommend Vacation 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
👀 기타 더 이야기해볼 점
어제 이야기하다가, 일정 추천 (일정 볼래말래) 페이지가 추가되어서
해당 부분 추가 작업할 예정입니다
그외에 구조적인 부분은 api 연동하면서 조금 변경할 예정입니다
공통 컴포넌트 추가 옵션 적용해둔 부분 디폴트는 둘 다 기존과 동일합니다
DS 텍스트필드 사용하는 피쳐들에서 숫자만 입력해야하는 경우에는 해당 옵션 사용하시면 좋을 것 같아요!
✔️ CI Completed
✔️ CI Completed
✔️ CI Completed