Skip to content

add new feature #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 18, 2024
Merged

add new feature #13

merged 5 commits into from
Oct 18, 2024

Conversation

masterhood13
Copy link
Owner

@masterhood13 masterhood13 commented Oct 18, 2024

now you could select only interseted matches , and not wait for all match prediction

Pull Request Title

Description

Please include a summary of the changes and the related issue number. Provide relevant motivation and context. If this fixes a bug or resolves a feature, include a link to the related issue.

  • Issue Number: [Issue #]
  • Description of changes: Explain the code, algorithms, or models modified/added.

Type of Change

Please delete options that are not relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactor
  • Performance improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Include any relevant details for configuration.

  • Unit Tests Added: [Yes/No]
    • If yes, describe the tests and if they were successful.
  • Model Accuracy Improvement: [Yes/No]
    • If yes, provide before and after metrics of the prediction model accuracy (e.g., accuracy, precision, recall, etc.)

Test Configuration:

  • Python version: [e.g., 3.9.19]
  • ML Framework/Library: [e.g., XGBoost]
  • Dataset: [e.g., all_data.csv]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Context or Screenshots (if applicable)

Include any additional context or relevant screenshots related to the prediction models or new features. If the change impacts the Dota 2 match prediction outcomes, provide graphs or results showing the impact.

masterhood13 and others added 2 commits October 18, 2024 08:31
now you could select only interseted matches , and not wait for all match prediction
@masterhood13 masterhood13 requested a review from vkatsuba October 18, 2024 06:39
Copy link
Collaborator

@vkatsuba vkatsuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If expected provide a minor release for this changes - need also update a version of project

@masterhood13 masterhood13 requested a review from vkatsuba October 18, 2024 07:31
@masterhood13
Copy link
Owner Author

If expected provide a minor release for this changes - need also update a version of project

done

version.py Outdated
@@ -1 +1 @@
__version__ = "1.1.0"
__version__ = "1.2.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is a major version? Please read https://semver.org. It looks like this should be or 1.1.1 or 1.2.0-rc.1 and after large changes and tests etc it can be released as well.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sounds reasonable

@masterhood13 masterhood13 merged commit be34850 into main Oct 18, 2024
1 check passed
@masterhood13 masterhood13 deleted the feature/select_match branch October 18, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants