-
Notifications
You must be signed in to change notification settings - Fork 3
add new feature #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new feature #13
Conversation
now you could select only interseted matches , and not wait for all match prediction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If expected provide a minor release for this changes - need also update a version of project
…redictor into feature/select_match
done |
version.py
Outdated
@@ -1 +1 @@ | |||
__version__ = "1.1.0" | |||
__version__ = "1.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is a major version? Please read https://semver.org. It looks like this should be or 1.1.1 or 1.2.0-rc.1 and after large changes and tests etc it can be released as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, sounds reasonable
now you could select only interseted matches , and not wait for all match prediction
Pull Request Title
Description
Please include a summary of the changes and the related issue number. Provide relevant motivation and context. If this fixes a bug or resolves a feature, include a link to the related issue.
Type of Change
Please delete options that are not relevant:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Include any relevant details for configuration.
Test Configuration:
Checklist
Additional Context or Screenshots (if applicable)
Include any additional context or relevant screenshots related to the prediction models or new features. If the change impacts the Dota 2 match prediction outcomes, provide graphs or results showing the impact.