Skip to content

just extend dataset and query fix #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

masterhood13
Copy link
Owner

@masterhood13 masterhood13 commented Oct 18, 2024

Pull Request Title

Description

Please include a summary of the changes and the related issue number. Provide relevant motivation and context. If this fixes a bug or resolves a feature, include a link to the related issue.

  • Issue Number: [Issue #]
  • Description of changes: Explain the code, algorithms, or models modified/added.

Type of Change

Please delete options that are not relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactor
  • Performance improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Include any relevant details for configuration.

  • Unit Tests Added: [Yes/No]
    • If yes, describe the tests and if they were successful.
  • Model Accuracy Improvement: [Yes/No]
    • If yes, provide before and after metrics of the prediction model accuracy (e.g., accuracy, precision, recall, etc.)

Test Configuration:

  • Python version: [e.g., 3.9.19]
  • ML Framework/Library: [e.g., XGBoost]
  • Dataset: [e.g., all_data.csv]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Context or Screenshots (if applicable)

Include any additional context or relevant screenshots related to the prediction models or new features. If the change impacts the Dota 2 match prediction outcomes, provide graphs or results showing the impact.

@masterhood13 masterhood13 requested a review from vkatsuba October 18, 2024 20:13
@masterhood13 masterhood13 requested a review from vkatsuba October 18, 2024 20:22
try:
match.get_match_data()
self.add_match(match)
except (TypeError, KeyError):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to cover it somehow by some tests?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a floating thing, somitimse opendota return broken data, which not contains all needed info, it occures once pre 500 matches, so i added it to not braek the runtime

@masterhood13 masterhood13 requested a review from vkatsuba October 18, 2024 20:26
@masterhood13 masterhood13 merged commit d572587 into main Oct 18, 2024
1 check passed
@masterhood13 masterhood13 deleted the fix/extended_dataset branch October 23, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants