-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add commands to download cursor rules #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.gitignore (1)
1-1
: Prefer ignoring the directory, not just its contents
Using.cursor-rules/*
ignores files inside the directory but not the directory itself (e.g., newly created subdirectories). It’s more robust to ignore the directory recursively:-.cursor-rules/* +.cursor-rules/lib/cursor/Taskfile.yml (3)
8-13
: DRY: Extract shared variables to top-level
Bothfetch-rule
andfetch-rules-all
repeatOWNER
,REPO
,REF
, andOUTDIR
. You can move these to a top-levelvars:
block to avoid repetition:version: "3" vars: OWNER: masterpointio REPO: internal-cursor-rules REF: main OUTDIR: .cursor-rules tasks: fetch-rule: vars: filename: '{{default "cursor_rules.mdc" .CLI_ARGS}}' ... fetch-rules-all: vars: SRC_DIR: rules ...Also applies to: 38-43
31-33
: Ensurecurl
is available in preconditions
You currently check forjq
(infetch-rules-all
) andGITHUB_TOKEN
, but don’t verify thatcurl
exists. Ifcurl
is missing, the download steps will fail unpredictably. Add acommand -v curl >/dev/null 2>&1
check to both tasks’preconditions
:preconditions: - command -v curl >/dev/null 2>&1 - test -n "$GITHUB_TOKEN"Also applies to: 71-73
26-30
: Improve error handling for downloads
By default,curl -sSL
will write HTTP error pages into your output files on failure. Add--fail
(-f
) so that non-2xx responses causecurl
to exit non-zero:- curl -sSL \ + curl -sSLf \Optionally, at the top of each shell block you could add
set -euo pipefail
to make any command failure abort the task immediately.Also applies to: 65-69
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.gitignore
(1 hunks)Taskfile.yaml
(1 hunks)lib/cursor/Taskfile.yml
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.yaml`: You are well-versed in writing and reviewing YAML configurations for the Task tool (https://taskfile.dev/). Provide recommendations for clarity, maintainability, and a...
**/*.yaml
: You are well-versed in writing and reviewing YAML configurations for the Task tool (https://taskfile.dev/).
Provide recommendations for clarity, maintainability, and adherence to Taskfile best practices, including usage of variables, environment blocks, and includes.
These configurations may also contain embedded Bash scripts or commands.
Demonstrate bash scripting best practices such as error handling, secure variable expansions, and clear documentation.
Taskfile.yaml
🔇 Additional comments (1)
Taskfile.yaml (1)
7-7
: Module inclusion looks good
The newcursor: lib/cursor
entry correctly integrates the cursor tasks into the rootTaskfile.yaml
.
7b463dd
to
0aea9da
Compare
…asterpointio/taskit into feat/add-cursor-rules-download-utility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.1...v0.4.0) (2025-06-04) ### Features * add commands to download cursor rules ([#20](#20)) ([de411c2](de411c2)) * small solutions for running task os:sync-all ([#23](#23)) ([0b2ddc3](0b2ddc3)) ### Bug Fixes * **snaplet:** add snaplet target DB var to SNAPSHOT_PATHs ([#25](#25)) ([f5e70c6](f5e70c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
what
taskit cursor:fetch-rule -- cursor_rules.mdc
taskit cursor:fetch-rules-all
why
references
Summary by CodeRabbit
.cursor-rules
directory from version control.