feat: configure NODE_ENV across bundlers #3642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 248c4d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ryan-mars is attempting to deploy a commit to the Mastra Team on Vercel. A member of the Team first needs to authorize it. |
|
✅ No documentation updates required. |
Add environment variable propagation through build chain, with development defaults for DevBundler and production defaults for standard bundling. Includes comprehensive test coverage.
wardpeet
approved these changes
Apr 18, 2025
wardpeet
force-pushed
the
fix/3610-respect-node-env
branch
from
4d7a783 to
248c4d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add environment variable propagation through build chain, with development defaults for DevBundler and production defaults for standard bundling. Includes comprehensive test coverage.
Description
This PR fixes an issue where the bundler hardcoded
process.env.NODE_ENVto"production"during all builds. The fix allows the actual environmentNODE_ENVto be respected during development while maintaining production defaults for standard bundling. I've implemented the solution as suggested by @wardpeet by adding an env option to the bundler chain.Related Issue(s)
#3610
Type of Change
Checklist