-
Notifications
You must be signed in to change notification settings - Fork 931
mssql provider #5849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mssql provider #5849
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 4525de5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@bala-intron is attempting to deploy a commit to the Mastra Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added MSSQL storage provider to Mastra, enabling Microsoft SQL Server as a backend option for memory storage and thread management.
stores/mssql/src/storage/index.ts
implements proper MSSQL-specific SQL syntax (square brackets, OFFSET/FETCH) and transaction handlingstores/mssql/docker-compose.yaml
anddocker-compose.perf.yaml
need security improvements and performance optimizations compared to PostgreSQL setup- Inconsistent version numbering (0.1.0) in
stores/mssql/package.json
deviates from organization's standard 0.2.0 .gitignore
and test configurations properly separate unit and performance tests, following project standards- CHANGELOG.md lacks proper versioning format and detailed documentation compared to other providers
13 files reviewed, 7 comments
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Implementation of MSSQL memory provider continues with test suite and storage logic improvements.
- Test suite in
stores/mssql/src/storage/index.test.ts
provides thorough validation of CRUD operations, schema isolation, and transaction rollbacks - Missing crucial memory optimization settings in
docker-compose.perf.yaml
for performance testing compared to PostgreSQL setup - Performance test configuration in
vitest.perf.config.ts
needs additional settings for thorough perf testing - Typescript configuration in
tsconfig.json
has overly restrictive test file exclusion that could miss performance tests
13 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
@TheIsrael1 @NikAiyer Please review this. Thanks |
@abhiaiyer91 Can you please approve the workflow run again? I have made changes to pnpm-lock file |
@abhiaiyer91 Fixed the issue with docker health check which made the connection socket hang up issue. Can you please approve the workflow runs again? Thanks |
@abhiaiyer91 fixed the lint issues. Can you please approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Can you also add some docs for this? The reference docs for storage adapters are located here: https://github.com/mastra-ai/mastra/tree/main/docs/src/content/en/reference/storage
@abhiaiyer91 @NikAiyer Removed perf tests and added doc. Please approve |
Add MSSQL Memory Provider to Mastra
Changes
stores/mssql
Why
This enables Mastra to use Microsoft SQL Server (MSSQL) as a backend for memory storage, offering users greater flexibility in database choices.