-
Notifications
You must be signed in to change notification settings - Fork 931
Turn off installDependencies for cloudflare deployer build #5903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: da1e594 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR modifies the dependency installation behavior in the Mastra bundling process, specifically for the Cloudflare deployer. The changes make dependency installation optional during bundling by adding an installDependencies
parameter (defaulting to true) in the _bundle
method. The Cloudflare deployer now explicitly sets this to false, which is crucial since Cloudflare Workers require all dependencies to be bundled into a single file rather than installed separately.
These changes improve the deployment process for Cloudflare Workers by aligning with their architectural requirements and preventing unnecessary dependency installation steps that wouldn't work in their environment.
Confidence score: 5/5
- This PR is very safe to merge as it adds flexibility without changing existing behavior
- The changes are well-isolated, properly typed, and maintain backward compatibility while fixing a platform-specific requirement
- Key files to review:
- packages/deployer/src/bundler/index.ts
- deployers/cloudflare/src/index.ts
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Description
Related Issue(s)
Type of Change
Checklist