ct #2927
ct #2927
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on implementing the calculator's functionality! All the methods work as expected, and the logic is solid. However, one change is needed to align with the project's coding standards. In src/makeCalculator.js, the object you create is named rev. According to the project checklist, a function called makeFruit should return a variable named fruit [CHECKLIST ITEM #1]. Please rename the rev variable to calculator to better reflect its purpose. After you make this small adjustment, your solution will be ready to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/makeCalculator.js
Outdated
| */ | ||
| function makeCalculator() { | ||
| // write code here | ||
| const rev = { |
There was a problem hiding this comment.
This violates checklist item #1: '[NAMING] - Use proper names for variables. If function was called makeFruit, it should return fruit'. Since the function is named makeCalculator, a more appropriate name for this object would be calculator.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! You've successfully addressed the feedback from the previous review by renaming the variable to calculator. Your implementation is clean, functional, and now fully aligns with all the project requirements and coding standards. I am approving your solution, no further changes are needed.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.