Solution #2931
Solution #2931
Conversation
DemonWayne
left a comment
DemonWayne
left a comment
There was a problem hiding this comment.
Looks okay, specified some minor problems below
| add(number) { | ||
| return this.result += number; | ||
| }, | ||
|
|
||
| subtract(number) { | ||
| return this.result -= number; | ||
| }, | ||
|
|
||
| multiply(number) { | ||
| return this.result *= number; | ||
| }, | ||
|
|
||
| divide(number) { | ||
| return this.result /= number; | ||
| }, | ||
|
|
||
| reset() { | ||
| this.result = 0; | ||
|
|
||
| return this; | ||
| }, |
There was a problem hiding this comment.
Those returns are unnecessary 'cause we use those functions as callbacks and don't really expect them to return anything, so I think we can remove those returns.
There was a problem hiding this comment.
Oh, don't mind that I also selected reset here; ignore this comment about reset.
src/makeCalculator.js
Outdated
| }, | ||
|
|
||
| divide(number) { | ||
| return this.result /= number; |
There was a problem hiding this comment.
I think that raw divide could be harmful and break all calculations if number is zero. We would probably get infinity, and that's maybe not an expected behavior for this calculator. Could you check if the number is zero and maybe throw an error or reset the result?
src/makeCalculator.js
Outdated
| }, | ||
|
|
||
| operate(callback, number) { | ||
| this.result = callback.call(this, number); |
There was a problem hiding this comment.
And here we don't need this assigning, we already assign value in the called callbacks
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am approving your submission. You've done an excellent job implementing the makeCalculator function. All requirements have been met, including the creation of all necessary methods and the correct implementation of method chaining for operate and reset. Your code is clean, well-structured, and adheres to all the style guidelines. Great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
3 participants
No description provided.