-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Solution #2935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Solution #2935
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job implementing the calculator's core logic! All the functional requirements are met, and the method chaining works perfectly.
However, one change is needed to align with the project's coding standards. The methods inside your calculator object are defined using arrow functions, but the project requires using the object method shorthand syntax, as mentioned in [CHECKLIST ITEM #3].
For example, instead of this:
add: (a, b) => a + bPlease refactor it to look like this:
add(a, b) {
return a + b;
}Once you apply this syntax to all the arithmetic methods, the submission will be ready for approval.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/makeCalculator.js
Outdated
| add: (a, b) => a + b, | ||
| subtract: (a, b) => a - b, | ||
| multiply: (a, b) => a * b, | ||
| divide: (a, b) => a / b, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates checklist item #3: '[CODE KNOWLEDGE] - if you creating a method in the object, you don't need to use function keyword, use shortcut instead.'
While arrow functions are concise, the project requires using the object method shorthand syntax for methods. For example, add: (a, b) => a + b should be written as add(a, b) { return a + b; }.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Excellent work on this iteration! You've successfully addressed the previous feedback by refactoring your methods to use the correct object shorthand syntax [CHECKLIST ITEM #3]. The code is now clean, fully functional, and meets all the project requirements. I'm approving your solution. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.