Develop #2941
Develop #2941
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on implementing the calculator's functionality! All the methods work correctly and meet the requirements. However, I am requesting one change to align with the project's coding standards.
Your makeCalculator function currently returns an object literal directly. This violates a specific naming convention outlined in the project's guidelines. [CHECKLIST ITEM #1]
To resolve this, please declare a constant within the function, assign your object to it (e.g., const calculator = { ... };), and then return that constant. This is a quick fix that will bring your code into full compliance with the checklist.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/makeCalculator.js
Outdated
| return { | ||
| result: 0, | ||
|
|
||
| operate(callback, number) { | ||
| this.result = callback(this.result, number); | ||
|
|
||
| return this; | ||
| }, | ||
|
|
||
| add(a, b) { | ||
| return a + b; | ||
| }, | ||
|
|
||
| subtract(a, b) { | ||
| return a - b; | ||
| }, | ||
|
|
||
| multiply(a, b) { | ||
| return a * b; | ||
| }, | ||
|
|
||
| divide(a, b) { | ||
| return a / b; | ||
| }, | ||
|
|
||
| reset() { | ||
| this.result = 0; | ||
|
|
||
| return this; | ||
| }, | ||
| }; |
There was a problem hiding this comment.
This violates checklist item #1: '[NAMING] - Use proper names for variables. If function was called makeFruit, it should return fruit'.
It's good practice to assign your object to a constant with a descriptive name (e.g., calculator) within the function, and then return that constant. This improves readability.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am approving your solution as it now meets all project requirements. You've successfully addressed the previous feedback, and the calculator's functionality is implemented correctly. The methods are properly chainable, and the code is clean and efficient. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.