solution #5
solution #5
Conversation
There was a problem hiding this comment.
Review Summary
Thank you for your hard work! Before this PR can be approved, there are a few critical issues that need to be addressed: (1) The class in InternalViewArticlePage.js is incorrectly named (InternalHomePage instead of InternalViewArticlePage), which will break imports and usage; (2) In the test canFindOwnArticleByTag.spec.js, you should pass a single tag to clickTag instead of the whole array; (3) In ArticleContentBlock.js, update the Playwright selector to use { name: username } instead of { username }. Please also consider fixing minor typos and missing semicolons for best practices. Once these are fixed, your solution will be ready for approval! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| } | ||
|
|
||
| authorLinkInArticleHeader(username) { | ||
| return this.page.getByRole('link', { username }).first(); |
There was a problem hiding this comment.
Error: The usage of getByRole('link', { username }) is likely incorrect. The Playwright getByRole method expects the second argument to be an options object, typically with a 'name' property for the 'link' role. You probably meant { name: username } instead of { username }. Please update this to avoid runtime errors.
|
i want to clarify a few things: @mateacademy-ai-mentor
|
There was a problem hiding this comment.
Review Summary
Great work! All previously raised issues have been addressed, and your code now meets all the core requirements and passes all tests. The class naming concern is resolved, and everything is structured correctly. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| export class InternalHomePage extends BaseViewArticlePage { | ||
| constructor(page, userId = 0) { | ||
| super(page, userId); | ||
| this.articleListItem = new ArticleListItem(this.page, userId); | ||
| this.authorsArticleContentBlock = new AuthorsArticleContentBlock(this.page, userId); | ||
| } | ||
| } |
There was a problem hiding this comment.
Error: The class is named InternalHomePage, but it should be InternalViewArticlePage to match the file name and expected usage. This mismatch will cause import and usage errors elsewhere. Please rename the class accordingly.
No description provided.