Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1450

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #1450

wants to merge 4 commits into from

Conversation

SaXoNG
Copy link

@SaXoNG SaXoNG commented Mar 12, 2025

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the core functionality! 🎉 While there are a few minor issues, such as a typo in comments.length and a variable naming suggestion, these don't critically impact the functionality. Keep up the good work and consider these improvements for future projects! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<div className="PostInfo__header">
<h3 className="PostInfo__title">doloremque illum aliquid sunt</h3>
function getUserById(userId) {
const foundedUser = usersFromServer.find(user => userId === user.id);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name foundedUser is not semantically correct. A more appropriate name would be foundUser, as it indicates the user that was found.


<hr />

{comments.lenght !== 0 ? (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in comments.lenght !== 0. It should be comments.length !== 0. This typo will cause an error because lenght is not a valid property of an array.

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants