Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #1458

wants to merge 2 commits into from

Conversation

Ga1dar
Copy link

@Ga1dar Ga1dar commented Mar 15, 2025

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 You're almost there! I noticed a minor issue regarding the key prop in your CommentList and PostList components. The review summary says: "In src/components/CommentList/CommentList.jsx, src/components/PostList/PostList.jsx, you are missing the key prop on the root element inside the .map function. This violates the checklist item: "ADD a key to the root tag inside an iteration (the first tag after the .map call)"." Adding this will ensure React can efficiently update the list. Keep up the great work! ✨

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

🤖 If you have any comments about this review, please leave a message in the Add a comment field below and mention me with @mateacademy-ai-mentor tag. I will read your message when I perform the next review of your pull request.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉 The code is well-structured and implements the required logic for fetching and preparing post data, and the components are correctly implemented and styled. key props were correctly added to CommentList.jsx and PostList.jsx. The styling in src/components is appropriate for each component. The code meets the requirements and constraints. Keep up the good work! Please review the comments to further improve your code and learn from this experience.

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants