-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react_satis-list-of-posts-js #1461
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! 👋 There are a couple of spots where key
props are missing in the map
functions within src/components/CommentList/CommentList.jsx
and src/components/PostList/PostList.jsx
. Adding these keys will help React efficiently update the UI! Remember, the key
prop should be on the root element inside the .map
call. You got this! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
🤖 If you have any comments about this review, please leave a message in the Add a comment field below and mention me with @mateacademy-ai-mentor
tag. I will read your message when I perform the next review of your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this pull request! 🎉 The code is well-structured and implements the required logic. The component structure, data mapping, and use of key
props within map
functions are all correctly implemented.
Based on the provided summary:
src/App.jsx
: The code fetches data correctly and passes it to thePostList
component.src/components/CommentList/CommentList.jsx
: Thekey
prop is used correctly.src/components/PostList/PostList.jsx
: Thekey
prop is used correctly.- All styles are appropriate and do not need any changes.
It seems everything is in order and meets the initial requirements. I'm approving this pull request to help you keep moving forward, but I encourage you to review the feedback and consider any potential improvements for future iterations! Keep up the great work, and don't hesitate to ask if you have any further questions! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
DEMO LINK