add task solution #1487
Open
add task solution #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Review Summary
Great job! 🎉 The code is well-structured and meets all the requirements, including the correct use of the key prop. The components render data correctly. Keep up the good work! 👍
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
volodymyr-soltys97
suggested changes
Apr 9, 2025
| {' by '} | ||
|
|
||
| <a className="CommentInfo__email" href={`mailto:${comment.email}`}> | ||
| {comment.email} |
There was a problem hiding this comment.
Use destructuring for comment
Comment on lines
+9
to
+11
| const foundUser = usersFromServer.find(user => user.id === post.userId); | ||
| const postComments = commentsFromServer.filter( | ||
| comment => comment.postId === post.id, |
There was a problem hiding this comment.
Move this logic to App component for fix failed tests
| return ( | ||
| <div className="PostInfo"> | ||
| <div className="PostInfo__header"> | ||
| <h3 className="PostInfo__title">{post.title}</h3> |
|
|
||
| export const UserInfo = ({ user }) => ( | ||
| <a className="UserInfo" href={`mailto:${user.email}`}> | ||
| {user.name} |
| @@ -1 +1,4 @@ | |||
| // add styles here | |||
There was a problem hiding this comment.
Remove comments
Suggested change
| // add styles here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK