result1 #1583
result1 #1583
Conversation
There was a problem hiding this comment.
Review Summary
Thank you for your hard work! There is one critical issue that needs to be addressed before we can approve your PR: the "No comments yet" message is currently being conditionally rendered in the PostInfo component, but according to the task checklist, this message should only be handled and displayed within the CommentList component. Please remove the conditional rendering from PostInfo and always render <CommentList comments={post.comments} />, letting CommentList handle the display logic. Once you make this change, your solution will fully meet the core requirements. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/PostInfo/PostInfo.jsx
Outdated
| {post.comments.length > 0 ? ( | ||
| <CommentList comments={post.comments} /> | ||
| ) : ( | ||
| <b data-cy="NoCommentsMessage">No comments yet</b> | ||
| )} |
There was a problem hiding this comment.
Issue: The 'No comments yet' message is conditionally rendered here, but according to the checklist, this message should only be shown in the CommentList component. Please remove this conditional and always render . Checklist reference: 'The message "No comments yet" should only be shown in the CommentList component, not in PostInfo.'
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your code fully meets all the core requirements and constraints of the task. All components are implemented correctly, the logic for rendering posts, users, and comments (including the "No comments yet" message) is handled as specified, and there are no missing or unnecessary files. Keep up the excellent work! If you want to further improve, you can always look into code style or optimizations, but for this task, everything is spot on. 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
DEMO LINK