-
Notifications
You must be signed in to change notification settings - Fork 1.6k
solution #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
solution #1585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Thank you for your hard work! There is one critical issue to address before your PR can be approved: the posts
variable is exported from src/App.jsx
, but according to the task requirements, only the App
component should be exported. Please remove the export
keyword from the posts
variable declaration. Once you make this small fix, your solution will fully meet the requirements. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review
button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor
tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/App.jsx
Outdated
export const posts = postsFromServer.map(post => ({ | ||
...post, | ||
user: getUserById(post.userId), | ||
comments: getCommentsByPostId(post.id), | ||
})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: The posts
variable is exported, but the checklist does not require or mention exporting this variable. According to the checklist, only the App
component should be exported. Please remove the export
keyword from the posts
variable declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job! 🎉 Your implementation meets all the core requirements and constraints of the task. All components are correctly structured, styled, and function as expected. There are no critical issues or missing functionalities. Keep up the excellent work and attention to detail!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
https://Vlad-2608.github.io/react_static-list-of-posts-js/