add task solution #1587
add task solution #1587
Conversation
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your implementation meets all the core requirements and works as expected. The only issue found is a minor naming inconsistency: the function getPostsById actually retrieves comments for a post, so renaming it to something like getCommentsByPostId would make your code clearer and easier to maintain. This doesn't affect functionality, so your PR is approved. Keep up the good work and consider improving naming conventions in future projects!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
src/App.jsx
Outdated
| function getPostsById(postId) { | ||
| return commentsFromServer.filter(comment => comment.postId === postId); | ||
| } |
There was a problem hiding this comment.
Issue: The function getPostsById is misleadingly named. It actually retrieves comments for a given post, not posts by ID. Consider renaming it to something like getCommentsByPostId to better reflect its purpose and avoid confusion.
DEMO LINK