Skip to content

solution #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #1600

wants to merge 2 commits into from

Conversation

Mitlosh
Copy link

@Mitlosh Mitlosh commented Jun 5, 2025

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job! 🎉 Your solution meets all the core requirements and the application is well-structured, functional, and follows the task guidelines. While there is a minor potential issue if a user is not found (which could cause a runtime error), this does not violate the explicit requirements for this task. For future projects, consider adding checks to handle such cases more robustly. Keep up the good work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines +18 to +19
name: getUser(post.userId).name,
email: getUser(post.userId).email,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential issue here: if getUser(post.userId) returns undefined (i.e., if a user with the given userId does not exist in usersFromServer), attempting to access .name or .email will cause a runtime error. You should add a check to ensure getUser(post.userId) is not undefined before accessing its properties, as required by robust data handling practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants