Fix get/set when shape = [] #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify min and max with reduce
optimize toString method
This badge will show the version on CDNJS!
add CDNJS version badge in README.md
add binary operation function to vector
add fill method to matrix
add binary operation to matrix
optimize for loop by pre-calculating size
add check method for Vector
make callback function takes original data array
…into Xuefeng-Zhu-patch-15
* Add prettier formatter * [skip ci] Bump version
* Remove non-null assertions * 6.1.8
* Remove non-null assertions * 6.1.8 * Split up iterators into separate files * 6.1.9
* Remove old benchmarks and add benchmarks to .gitignore * Add benchmarks to iterators * Improvement/renaming to bench script * 6.1.10
…#239) * Remove next2d and next1d from NDIter and add test case * 6.1.11
* Improve test for multidimensional iterator * Improve tests for matrix multiply * Add blas.ts tests (except gemm) * Test unoptimized path for add() * Test unoptimized path for dot() * Test unoptimized path for inv() * Test unoptimized path for multiply()
use rimraf instead of `rm -rf`. This makes the build work on Windows. Co-authored-by: Mateo Gianolio <[email protected]>
github-actions
bot
force-pushed
the
master
branch
from
689a750
to
5037139
Compare
|
Sorry, something exploded with github-actions and it automatically closed your pull requests and I can't reopen them.. I'll try to fix it when I have time. |
|
no worries! let me know when you are ready and I’ll make my PRs again |
|
I have reset the repository now so you can reopen the PRs whenever you are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this also fixes a pretty big bug with set, where the index would not be properly set for a multi-dimensional array. Recommend adding a test.