-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NEB schemas #1123
base: main
Are you sure you want to change the base?
Add NEB schemas #1123
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
===========================================
- Coverage 90.42% 72.59% -17.84%
===========================================
Files 147 77 -70
Lines 14448 5101 -9347
===========================================
- Hits 13065 3703 -9362
- Misses 1383 1398 +15 ☔ View full report in Codecov by Sentry. |
461dc08
to
0bbea06
Compare
Adding support for parsing NEB calculations and eventually ApproxNEB calculations. These are still VASP calculations, but have a directory structure which is not parseable by TaskDoc (at least meaningfully). The structure is:
./{INCAR, KPOINTS, POTCAR}
./00/POSCAR
./01/{vasprun.xml, OSZICAR, OUTCAR, CHGCAR, ... }
./02/{vasprun.xml, OSZICAR, OUTCAR, CHGCAR, ... }
...
./0N/POSCAR
Approx / NEB calculations are needed for battery cathode and alloy diffusivity calculations. These schemas will be needed for atomate2 workflows. Once Approx / NEB flows are added to atomate2, we should have full parity with atomate. This will also make it easier to host data from these calculations
Supports parsing NEB calculations (only relaxes images) and NEB + endpoints (three total calculations, two relaxes + one NEB)
Possibly worth adding run / task / calc types? Since this requires a separate doc model, maybe we should avoid this?