Add emmet-archival namespace package, part 1#1190
Add emmet-archival namespace package, part 1#1190tsmathis merged 104 commits intomaterialsproject:mainfrom
Conversation
* update dependencies for emmet-api (ubuntu-latest/py3.10) * update dependencies for emmet-api (ubuntu-latest/py3.11) * update dependencies for emmet-builders (ubuntu-latest/py3.10) * update dependencies for emmet-builders (ubuntu-latest/py3.11) * update dependencies for emmet-core (ubuntu-latest/py3.10) * update dependencies for emmet-core (ubuntu-latest/py3.11) --------- Co-authored-by: github-actions <github-actions@github.com>
overlooked in pydantic v2 transition
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.1.2 to 5.3.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.1.2...v5.3.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* update dependencies for emmet-api (ubuntu-latest/py3.10) * update dependencies for emmet-api (ubuntu-latest/py3.11) * update dependencies for emmet-builders (ubuntu-latest/py3.10) * update dependencies for emmet-builders (ubuntu-latest/py3.11) * update dependencies for emmet-core (ubuntu-latest/py3.10) * update dependencies for emmet-core (ubuntu-latest/py3.11) --------- Co-authored-by: github-actions <github-actions@github.com>
* update dependencies for emmet-api (ubuntu-latest/py3.10) * update dependencies for emmet-api (ubuntu-latest/py3.11) * update dependencies for emmet-builders (ubuntu-latest/py3.10) * update dependencies for emmet-builders (ubuntu-latest/py3.11) * update dependencies for emmet-core (ubuntu-latest/py3.10) * update dependencies for emmet-core (ubuntu-latest/py3.11) --------- Co-authored-by: github-actions <github-actions@github.com>
* update dependencies for emmet-api (ubuntu-latest/py3.10) * update dependencies for emmet-api (ubuntu-latest/py3.11) * update dependencies for emmet-builders (ubuntu-latest/py3.10) * update dependencies for emmet-builders (ubuntu-latest/py3.11) * update dependencies for emmet-core (ubuntu-latest/py3.10) * update dependencies for emmet-core (ubuntu-latest/py3.11) --------- Co-authored-by: github-actions <github-actions@github.com>
|
@tschaume to keep other PRs moving (like Karlo's new CLI) and to ensure we're making more easily-reviewed changes to new namespaces, going to checkpoint the archival package here. More updates will go into a separate PR Most of the changes to emmet-core are additive. The only thing you might want to check @tsm is that the phonon bandstructure and DOS schemas still are OK with OpenData. These just inherit from a new base class which schematizes generic bandstructure and DOS objects |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
- Coverage 89.45% 88.92% -0.54%
==========================================
Files 151 161 +10
Lines 15756 16545 +789
==========================================
+ Hits 14095 14712 +617
- Misses 1661 1833 +172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tschaume
left a comment
There was a problem hiding this comment.
Wow, great work! I only have nit-picky comments to go through.
Summary
Adds an
archivalnamespace package toemmetto establish MP's data archival formats moving forward. This package should be flexible enough to permit new data formats as they become relevant (e.g., data from phonopy, LOBSTER, etc.)Archiverclass that defines a schema for how data is to be archived / retrieved from HDF5 + zarr filesRawArchiveclass:TaskDocfrom HDF5/zarr dataVolumetricArchive+ separate volumetric data classes: formats for convertingCHGCAR-structured files, bandstructures, and DOS to HDF5/zarr/parquetChanges to emmet-core
band_theorymodule for schemas of generic densities of states and band structures (electronic, phonon, etc.)To Do's: