Clean up io.vasp.outputs.Outcar docstring#4160
Merged
shyuep merged 44 commits intomaterialsproject:masterfrom Jan 18, 2025
Merged
Clean up io.vasp.outputs.Outcar docstring#4160shyuep merged 44 commits intomaterialsproject:masterfrom
io.vasp.outputs.Outcar docstring#4160shyuep merged 44 commits intomaterialsproject:masterfrom
Conversation
DanielYang59
changed the title
io.vasp.Outcar docstringio.vasp.outputs.Outcar docstring
DanielYang59
commented
Nov 9, 2024
DanielYang59
force-pushed
the
outcar-parse-nbands
branch
2 times, most recently
from
dfb33f7 to
404ed50
Compare
DanielYang59
force-pushed
the
outcar-parse-nbands
branch
from
404ed50 to
6b80819
Compare
DanielYang59
force-pushed
the
outcar-parse-nbands
branch
from
e5783c7 to
f3dc1e1
Compare
This reverts commit 6b80819.
DanielYang59
commented
Nov 12, 2024
This reverts commit 4363d1b.
DanielYang59
commented
Nov 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up
io.vasp.outputs.Outcardocstring/commentOutcarwith more specific types, clarify docstring:Renders accessible from self.data(the internalself.datadictionary) vsRenders accessible from attributes(instance attributes)Others
getattrdefault value toFalseinstead ofNonewhen used for condition check