Closed
Conversation
pi8027
requested changes
Jan 20, 2025
Member
pi8027
left a comment
pi8027
left a comment
There was a problem hiding this comment.
IMO, baseAddMagmaType and baseAddUMagmaType instances should rather be stored in the additive and rmorphism datatypes for performance reasons. I'm fine with dropping the support for released versions of MathComp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
math-comp/math-comp#1256 generalizes operations. This PR generalizes everything that was on
nmodTypetobaseAddUMagmaType(and addition toaddMagmaType). It also changes themempredicate incommon.elpito usecoq.unify-eqbecauseelpi's unification is not module delta, which causes issues when N-modules are cast tobaseAddUMagmaType.