Skip to content

Conversation

@GiovanniCanali
Copy link
Collaborator

Description

This PR fixes #716

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@GiovanniCanali GiovanniCanali self-assigned this Nov 24, 2025
@GiovanniCanali GiovanniCanali added enhancement New feature or request pr-to-fix Label for PR that needs modification labels Nov 24, 2025
@GiovanniCanali
Copy link
Collaborator Author

GiovanniCanali commented Nov 24, 2025

Added minor changes to the doc of all problems in the zoo, namely default values, explicit argument specifications, and missing doc strings.

@GiovanniCanali GiovanniCanali mentioned this pull request Nov 24, 2025
4 tasks
@GiovanniCanali GiovanniCanali marked this pull request as ready for review November 24, 2025 09:43
@GiovanniCanali GiovanniCanali requested review from a team and dario-coscia as code owners November 24, 2025 09:43
@GiovanniCanali GiovanniCanali added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Nov 24, 2025
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I added few comments.

  1. For the wave equation everything is fine, just need to add the mathematical description.
  2. There are a bunch of other files which should be removed from this PR. Also many file introduce value=0 instead of 0. I would not do it, motivation below. For the fact that you change also the doc in many files to specify the init variables, what is the rationale? They are already written in the doc.

@GiovanniCanali GiovanniCanali merged commit c76cf21 into mathLab:dev Nov 25, 2025
18 of 19 checks passed
@GiovanniCanali GiovanniCanali deleted the wave_problem branch November 25, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants