Feature/#145 default_draft_bump#177
Open
lazyBisa wants to merge 5 commits intomathieudutour:masterfrom
Open
Conversation
…efaultPreReleaseBump only when updating a prerelease version **BREAKING CHANGE:** this change changes the behaviour of drafting prereleases
Author
|
@davidolrik @sebbacon @jimrazmus @duality72 anyone up to do a review on this? Fixes a quite unpleasant bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
even though the default_bump would increment a version
1.2.3to1.3.0, doing a prerelease for that version creates a1.2.4-RC.0instead of1.3.0-RC.0.Since changing this behavior would be a breaking change, I introduced a
default_draft_bumpinput to explicitly specify what default version increment should happen when a prerelease version is drafted on top of a non-prerelease version. (see example in testcases)fixes #145