RFC: feat: Adding commit filtering by path #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sha: '4567', | ||
| }, | ||
| ]; | ||
| // @ts-ignore |
Author
There was a problem hiding this comment.
I would tidy this up for a proper PR
findmyname666
added a commit
to findmyname666/github-tag-action
that referenced
this pull request
Aug 5, 2025
| .filter((commit) => | ||
| !targetPath | ||
| ? true | ||
| : commit.files?.some((file) => file.filename?.includes(targetPath)) |
There was a problem hiding this comment.
Suggested change
| : commit.files?.some((file) => file.filename?.includes(targetPath)) | |
| : commit.files?.some((file) => file.filename?.startsWith(targetPath)) |
I'm not maintainer but it seems to me that includes can create false positives when some sub-string is matched.
|
I created a new PR #236. It introduces working solution for commit filtering based on a path of changed files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We use
github-tag-actionto generate semver versions and then release notes for a number of projects. We are also using it in a monorepo with 2 different apps and this is where we're running into issues. Becausegithub_tag_actionlooks at all the commits since the last tag we end up with a bunch of unrelated changes being considered e.g.Where ideally we'd only have one bump per app.
Solution
This is quick illustrative PR to explain how I might use the
github-tag-actionwith a mono repo. In this change I added a path based filter to thegetCommits- it's not wired through to the config / params that mean people can use it but I wanted to share this approach early to get some feedback before going any further.Thoughts, comments, criticisms welcome.