Skip to content

Update build and ui/menu so its builds with new highligher #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jun 17, 2025

This PR fixes a problem with building the ui/menu component. The components/bin/build command is modified to handle export async function which was causing an error during the build phase. The ts/a11y/sre.ts function also was causing problems when webpacking the ui/menu component. The the SRE functions for the preferences were not being found by webpack for some reason that I could not fully determine. I don't see anything wrong in any of the files, but it seems to be connected to the direct export of those methods in ts/a11y/res.ts, so I've change those to an import followed by exports, which seems to do the trick.

In addition, I've added a generic highlighter in ts/a11y/explorer/Highlighter.ts so that it can work in the absense of an output jax (I have an example in the documentation of a a role-you-own output jax for native MathML that causes an error otherwise).

I also add a new named STATE value in ts/handler/html/HTMLDocument.ts just for convenience, and so that all the default render actions have a named state value.

@dpvc dpvc added this to the v4.0 milestone Jun 17, 2025
@dpvc dpvc requested a review from zorkow June 17, 2025 16:54
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.69%. Comparing base (351698e) to head (07eae1a).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1276   +/-   ##
========================================
  Coverage    86.68%   86.69%           
========================================
  Files          337      337           
  Lines        84105    84110    +5     
  Branches      4750     4752    +2     
========================================
+ Hits         72909    72917    +8     
+ Misses       11173    11170    -3     
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 0204242 into develop Jun 20, 2025
3 checks passed
@dpvc dpvc deleted the fix/build branch June 20, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants