Brands renaming #8109

Simbiat · 2025-09-21T18:39:18Z

Description:

Split from #8096 this covers brand name changes, that are mostly more than just addition of a prefix or otherwise more contentious

Review

Simbiat · 2025-12-15T12:57:38Z

So, what's stopping us from merge? I'd like to update the other PRs with similar logic for "removed" brands

Simbiat · 2025-12-30T07:25:20Z

bump

Simbiat · 2026-01-15T06:58:42Z

Kind reminder

regexes/device/mobiles.yml

liviuconcioiu · 2026-01-21T05:58:50Z

@sgiehl I've reviewed the changes, all are fine for me. @sanchezzzhak if you can take a second look please?

regexes/device/mobiles.yml

Tests/fixtures/tv-4.yml

Tests/fixtures/feature_phone.yml

Tests/fixtures/smartphone.yml

Tests/fixtures/tablet-10.yml

Simbiat · 2026-01-26T10:20:17Z

Fails on composer

dyld[5847]: Library not loaded: @loader_path/../../../../opt/jpeg/lib/libjpeg.9.dylib
  Referenced from: <2E6E9A91-A871-384A-A669-F914E7D3FB65> /opt/homebrew/Cellar/[email protected]/7.2.34_15/bin/php
  Reason: tried: '/opt/homebrew/Cellar/[email protected]/7.2.34_15/bin/../../../../opt/jpeg/lib/libjpeg.9.dylib' (no such file)
/Users/runner/work/_temp/bc4ad433-2388-4fc1-9862-96d78e1273aa.sh: line 1:  5847 Abort trap: 6           composer install

don't think this was caused by me 😅

sanchezzzhak · 2026-01-27T18:47:24Z

regexes/device/mobiles.yml


-# Star
-Star:
+# Kingelon (previously "Star", which seems to be as valid as "Tengda", since a bunch of devices were released both under Kingelon and Star or/and Tengda, for example https://www.needrom.com/download/star-n8800-miui-tengda-kingelon/, but only Kingelon seems to have a logo at least, which is at least some evidence of it being real)


# Kingelon

sanchezzzhak · 2026-01-27T18:47:46Z

regexes/device/mobiles.yml

    - regex: 'Cherry(?:[ _]?Mobile)?[ _]?([^/;]+)(?: Build|[);])'
      model: '$1'

+      #Previously listed as "White Mobile" brand, but based on https://firmwarefile.com/cherry-mobile-omega-lite-3, https://forum.gsmhosting.com/vbb/f296/cherry-mobile-omega-lite-3-frp-remove-2259709/ and https://deviceatlas.com/device-data/devices/white-mobile/am1010v/30376111 (and others), this is likely "Cherry Mobile", especially since I was not able to find any evidence of "White Mobile" ever existing.


Remove this comment

Cherry Mobile should stay with the old name.
https://www.gadgetpilipinas.net/2016/12/cherry-mobile-defender/

The AM1010V can be separated into a separate brand.

sanchezzzhak · 2026-01-27T18:49:30Z

regexes/device/mobiles.yml


-# TechSmart or Techmade
-TechSmart:
+# Techmade (often seen as TechSmart, which is actually a model line: https://www.ebay.it/itm/112931113112 https://www.ebay.it/itm/123071096677 https://www.facebook.com/661598300623815/photos/a.661606387289673/1242575672526072/?type=3&locale=hi_IN)


# Techmade

sanchezzzhak · 2026-01-27T18:55:08Z

regexes/device/mobiles.yml

 # Newman
 Newman:
-  regex: 'Newman[ _](P308|K1|G5i)(?:[);/ ]|$)'
+  regex: '(?:(?:(?:Newman[ _])(P308|K1|G5i))|(UE Pad 1))(?:[);/ ]|$)'


regex: '(?:(?:Newman[ _])(?:P308|K1|G5i)|UE Pad 1)(?:[);/ ]|$)' device: 'smartphone' models: - regex: 'Newman[ _](P308|K1|G5i)(?:[);/ ]|$)' model: '$1' - regex: 'UE Pad 1' device: 'tablet' model: 'UE 1 PAD'

sanchezzzhak · 2026-01-27T18:57:57Z

regexes/device/mobiles.yml


 # 360 or names Qihoo 360, +360, QiKU 360
-'360':
+360:


rollback quotation
Other program languages will perceive this key not as a string, but as a number, for example, in nodejs.

sanchezzzhak · 2026-01-27T19:00:55Z

regexes/device/mobiles.yml


-# ROiK
-ROiK:
+# KAP (previously ROiK, but that's a model according to this https://www.youtube.com/watch?v=g9TNZJFTTsE)


sanchezzzhak · 2026-01-27T19:02:24Z

regexes/device/mobiles.yml


-# Padpro
-Padpro:
+# 7Ke tree (previously "Padpro", but "Padpro" seem like a model line, for example at least https://www.ebay.com/itm/404866696988 and https://www.ubuy.com.se/en/product/G68Y4S8AO-new-listing-14-inch-big-screen-tablet-pc-android-13-16gb-ram-512gb-rom-deca-core-keyboard?ref=hm-google-redirect seem like the same device)


# 7Ke tree

sanchezzzhak · 2026-01-27T19:04:30Z

regexes/device/mobiles.yml


-# HLLO or Exertis HLLO
-HLLO:
+# Exertis (previously HLLO, but was not able to find any evidence of this being a brand besides it being part of Exertis accelerator. Search for the model also shows Exertis most of the times, so HLLO is probably a model line rather than a (sub-)brand)


# Exertis

sanchezzzhak · 2026-01-27T19:06:28Z

regexes/device/mobiles.yml


-# Sprint
-Sprint:
+# Quanta Computer ("Sprint" in previous versions, but "Sprint" seems to be a distributor brand (possibly https://en.wikipedia.org/wiki/Sprint_Corporation but no clear evidence was found at the time of writing), similar some HTC models https://phonedb.net/index.php?m=device&s=query&d=detailed_specs&brand=Sprint#result)


# Quanta Computer

sanchezzzhak · 2026-01-27T19:09:08Z

Parser/Device/AbstractDeviceParser.php

    public static function getShortCode(string $brand): string
    {
-        return (string) \array_search($brand, self::$deviceBrands, true) ?: '';
+        return (string) \array_search($brand, self::$legacyShortNames + self::$deviceBrands, true) ?: '';


Return the old code, as this merging of arrays does not carry payload.

return (string) \array_search($brand, self::$deviceBrands, true) ?: '';

and remove $legacyShortNames

Not sure I understand, what you mean by "does not carry payload". This was done as a way to preserve old names (essentially backwards compatibility), as discussed here

$getShortCode = function(string $brand): string { $legacyShortNames = [ '6T' => 'Twoe', '5H' => 'MMI', 'WHI' => 'White Mobile', '6C' => 'Cloudpad', 'DZ' => 'Dazen', 'ER' => 'Ericy', 'HLL' => 'HLLO', 'EKI' => 'EKINOX', 'LPX' => 'LPX-G', 'UE1' => 'UE', ]; $deviceBrands = [ '6T' => '2E', '5H' => 'ARRIS', 'WHI' => 'Cherry Mobile', '6C' => 'Cloudfone', 'DZ' => 'Coolpad', 'ER' => 'Ericsson', 'HLL' => 'Exertis', 'EKI' => 'iGet', 'LPX' => 'OTT', 'UE1' => 'Newman', 'TEST' => 'test brand', ]; dump(legacyShortNames + $deviceBrands); // result only key => value for $legacyShortNames and append new keys/values 'TEST' => '' return (string) \array_search($brand, $legacyShortNames + $deviceBrands, true) ?: ''; }; dd( $getShortCode('Twoe'), // result "6T" $getShortCode('2E'), // result "" $getShortCode('Cherry Mobile'), // result "" $getShortCode('White Mobile'), // result "WHI" $getShortCide('test brand') // result "TEST" );

If we are trying to make compatibility, we must fulfill 2 conditions sequentially

$shortcode = (string) \array_search($brand, self::$deviceBrands, true) ?: ''; if ($shortcode !== '') { return $shortcode; } return (string) \array_search($brand, self::$legacyShortNames, true) ?: '';

Dmitrii Kustov added 30 commits September 21, 2025 21:13

Wortmann to Terra

30a7f7d

VOX to VOX Electronics

f603f9f

VK Mobile to Viable Korea

ba4eb54

TWX to TWZ Corporation

9f34cd0

Twoe to 2E

2059669

TPS to SZ TPS

ae0615f

Spark to Spark NZ

f57b6b6

TechSmart to Techmade

02e0b1b

Stream to Stream System

837379d

Moved Hisense devices to Smartfren

148e3a1

UE is Newman

084c0ef

Sprint to Quanta Computer

a3b877c

Star to Kingelon

f03e519

Megamax and Polarline to Polar

ee586d2

White Mobile to Cherry Mobile

6db928a

Wanmukang to Zhongyu Display

0aa2f69

Padpro to 7Ke tree

a24c1a0

P-UP to Mode 1

26ac48e

MMI to ARRIS

e27f217

MLAB to Microlab

5aad0a8

MDTV to OTT

4a93667

LPX-G to OTT

f84aca6

HLLO to Exertis

a0dc613

High Q to EPIK Learning

b7c3f8d

BASE to Unikalne Smartphones

667e9ee

Cloud to Cloud Mobile

b5ede6e

Cloudpad to Cloudfone

80099f8

Crius Mea to Ooredoo

49a0c3a

Dazen to Coolpad

02b403c

Digit4G to Digit

fc1b13e

Merge branch 'master' into BrandsRenaming

bca4c60

Merge branch 'master' into BrandsRenaming

e74efec

liviuconcioiu reviewed Jan 21, 2026

View reviewed changes

regexes/device/mobiles.yml Outdated Show resolved Hide resolved

Simbiat added 3 commits January 21, 2026 07:21

Added Pelephone URL

efac743

Merge branch 'master' into BrandsRenaming

ae8bca0

Added Techmade URL

09668f3

liviuconcioiu reviewed Jan 21, 2026

View reviewed changes

regexes/device/mobiles.yml Outdated Show resolved Hide resolved

Simbiat added 2 commits January 21, 2026 07:44

Revert Ditecma

928d167

Revert Gini

58d9a89

liviuconcioiu reviewed Jan 21, 2026

View reviewed changes

regexes/device/mobiles.yml Outdated Show resolved Hide resolved

Fix for Ditecma test

027643d

Simbiat mentioned this pull request Jan 21, 2026

Prepare release #8235

Merged

10 tasks

Merge branch 'master' into BrandsRenaming

553ae6e

sanchezzzhak reviewed Jan 23, 2026

View reviewed changes

Tests/fixtures/tv-4.yml Outdated Show resolved Hide resolved

Simbiat added 3 commits January 24, 2026 17:22

Reverted PolarLine and MEGAMAX

97675d8

Merge branch 'master' into BrandsRenaming

f3334a3

Correct case for PolarLine

7b1776f

sanchezzzhak reviewed Jan 24, 2026

View reviewed changes

Tests/fixtures/feature_phone.yml Show resolved Hide resolved

sanchezzzhak reviewed Jan 24, 2026

View reviewed changes

Tests/fixtures/smartphone.yml Show resolved Hide resolved

sanchezzzhak reviewed Jan 24, 2026

View reviewed changes

Tests/fixtures/tablet-10.yml Show resolved Hide resolved

Simbiat added 2 commits January 26, 2026 12:11

Remove Terra from model names

c92cd86

Remove Terra from model names

d79bd6f

Simbiat added 2 commits January 27, 2026 08:16

Merge branch 'master' into BrandsRenaming

8f59bf1

Merge branch 'master' into BrandsRenaming

9ec92ca

sanchezzzhak requested changes Jan 27, 2026

View reviewed changes

Brands renaming #8109

Are you sure you want to change the base?

Brands renaming #8109

Conversation

Simbiat commented Sep 21, 2025

Description:

Review

Uh oh!

Simbiat commented Dec 15, 2025

Uh oh!

Simbiat commented Dec 30, 2025

Uh oh!

Simbiat commented Jan 15, 2026

Uh oh!

Uh oh!

Uh oh!

liviuconcioiu commented Jan 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Simbiat commented Jan 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants