Attempt to get CI working again #240
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dstansby, thanks for your work on this. I was thinking earlier that we could remove most of the hardcoded hashes in the tests by generating them during the test run: 1) run code to generate hashes 2) modify/break some hashes 3) test that pytest-mpl passes and fails correctly when rerun. It removes the flakiness, but does mean that we only test that matplotlib can produce identical hashes over repeated runs and not necessarily over different matplotlib or OS versions. What do you think? Here's my PR: #234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my (in progress) attempt to get CI up and running again. I don't have time to work on this further, so someone else should feel free to take this and run with it.
I noticed that with Matplotlib 3.10 hashes seem to vary based on operating system.