Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more methods for converting to/from sender IDs #412

Merged
merged 5 commits into from
Sep 8, 2023

Conversation

swedgwood
Copy link
Contributor

Including some tests for sender IDs

Signed-off-by: Sam Wedgwood <[email protected]>

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 77.27% and project coverage change: +0.15% 🎉

Comparison is base (740f742) 58.40% compared to head (484e769) 58.56%.

❗ Current head 484e769 differs from pull request most recent head c0669e0. Consider uploading reports for the commit c0669e0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   58.40%   58.56%   +0.15%     
==========================================
  Files          51       51              
  Lines        7040     7062      +22     
==========================================
+ Hits         4112     4136      +24     
+ Misses       2538     2534       -4     
- Partials      390      392       +2     
Files Changed Coverage Δ
spec/userid.go 84.61% <60.00%> (-2.62%) ⬇️
spec/senderid.go 81.25% <82.35%> (+47.91%) ⬆️

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

spec/userid.go Outdated Show resolved Hide resolved
@swedgwood swedgwood merged commit 47bceff into main Sep 8, 2023
5 checks passed
@swedgwood swedgwood deleted the swedgwood/senderid-features branch September 8, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants