Update linter config #442
Merged
Update linter config #442
+21
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ioutil` is deprecated, and on all the versions of Go we support, its functionality is replaced with `io`.
If the error message returned by the server contained a `%` character, `Errorf` would attempt to interpolate it, causing a panic.
The `deadcode`, `varcheck` and `structcheck` linters are all subsets of `unused` (which is enabled by default`) cf: golangci/golangci-lint#1841
These are replaced with `govet`, which is enabled by default.
`maligned` is apparently replaced with `govet fieldalignment`, but enabling that produces a million errors so I haven't done that. `golint` is apparently close to `revive`, but again that produces lots of warnings. `interface` apparently made bad suggestions and is removed without replacement.
Dendrite no longer builds against go 1.20, since matrix-org/dendrite#3360
S7evinK
approved these changes
Nov 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 59.89% 59.89%
=======================================
Files 51 51
Lines 7154 7154
=======================================
Hits 4285 4285
Misses 2477 2477
Partials 392 392 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of changes to get the linter (and CI in general) passing again.
Review commit-by-commit for details of the changes.