make the abuse report test more readable #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoric
reviewed
May 10, 2022
| await goodUser.doRequest("POST", `/_matrix/client/r0/rooms/${encodeURIComponent(roomId)}/report/${encodeURIComponent(badEventId)}`); | ||
| reportsToFind.push({ | ||
| let reportsToFind = [ | ||
| { |
| }); | ||
| reportsToFind.push({ | ||
| }, | ||
| { |
There was a problem hiding this comment.
// Text report, with a comment.
| await goodUser.doRequest("POST", `/_matrix/client/r0/rooms/${encodeURIComponent(roomId)}/report/${encodeURIComponent(badEventId3)}`, ""); | ||
| reportsToFind.push({ | ||
| }, | ||
| { |
There was a problem hiding this comment.
// Report containing embedded html, no comment.
| await goodUser.doRequest("POST", `/_matrix/client/r0/rooms/${encodeURIComponent(roomId)}/report/${encodeURIComponent(badEventId4)}`, ""); | ||
| reportsToFind.push({ | ||
| }, | ||
| { |
There was a problem hiding this comment.
// Report containing long that should be truncated by the report manager because it is too long.
| await goodUser.doRequest("POST", `/_matrix/client/r0/rooms/${encodeURIComponent(roomId)}/report/${encodeURIComponent(badEventId5)}`, ""); | ||
| reportsToFind.push({ | ||
| }, | ||
| { |
There was a problem hiding this comment.
// Report containing long that should be truncated by the report manager because it contains too many newlines.
| console.error("Could not send fifth report", e.body || e); | ||
| throw e; | ||
| } | ||
| ] |
| null, | ||
| report.comment ? { reason: report.comment } : null | ||
| ); | ||
| reportsToFind.push(report); |
There was a problem hiding this comment.
Isn't the report already in reportsToFind?
| @@ -276,6 +257,7 @@ describe("Test: Reporting abuse", async () => { | |||
| await new Promise(resolve => setTimeout(resolve, 1000)); | |||
|
|
|||
| let mjolnirRooms = new Set(await matrixClient().getJoinedRooms()); | |||
| // but you invited them???? | |||
There was a problem hiding this comment.
I don't understand that comment.
| if (roomId = this.mjolnir.managementRoomId) { | ||
| notices.push(event); | ||
| } | ||
| if (notices.length === reportsToFind.length) { |
There was a problem hiding this comment.
I'd be more comfortable if we made this a set or a map and removed reports as they arrive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is complete, but this test was extremely difficult to debug before #282 was discovered (and would still be).