Skip to content

Use spoilers when mentioning targets of a rule#559

Merged
H-Shay merged 4 commits intomainfrom
shay/spoiler
Nov 22, 2024
Merged

Use spoilers when mentioning targets of a rule#559
H-Shay merged 4 commits intomainfrom
shay/spoiler

Conversation

@H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Oct 30, 2024

fixes #73

@H-Shay H-Shay requested a review from a team as a code owner October 30, 2024 21:02
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm - thanks!

msgtype: "m.text",
body: `Applying ACL in ${roomId}.`,
format: "org.matrix.custom.html",
formatted_body: `Applying ACL in <span data-mx-spoiler>${roomId}</span>.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to escape HTML in all these spoilers. There should already be a function for it, somewhere.

@H-Shay H-Shay requested a review from turt2live November 22, 2024 16:57
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use spoilers when mentioning targets of a rule

2 participants