Update minimum memlimit for policy.rs to fix runtime error#162
Open
unullmass wants to merge 1 commit intomatrix-org:mainfrom
Open
Update minimum memlimit for policy.rs to fix runtime error#162unullmass wants to merge 1 commit intomatrix-org:mainfrom
unullmass wants to merge 1 commit intomatrix-org:mainfrom
Conversation
Member
|
Whilst I don't see any harm with upping the minimum memory linked with the module (other that it will allocate one potentially unused 64k page by default), I'm not sure I see the point of enabling memory64 support? OPA's WASM module won't use it, and the memory type allocated to it is not in 64bit mode either? |
Author
|
@sandhose I have removed the code pertaining to 64-bit memory from the above example. |
Member
|
Sure, but then what is this PR fixing exactly? The example should work without this PR, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #161.
Able to see the evaluation result now for this code:
Error: could not find entrypoint hello/world