Skip to content

Fix bug where rails new used 8.0.0.rc1 instead of the intended 7.2.1 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mattbrictson
Copy link
Owner

@mattbrictson mattbrictson commented Oct 29, 2024

Nextgen currently targets Rails 7.2. However, if someone has a prerelease version of the Rails gems installed, e.g. 8.0.0.rc1, then the rails new command issued by Nextgen will use the 8.0.0.rc1 version. This is confusing, because picking "7.2.1" from the interactive menu in Nextgen will end up creating an 8.0 app.

Fix by using the RubyGems underscored version argument when calling the rails new command:

rails _7.2.1_ new ...

This tells RubyGems the explicit version of the rails binary that we want to use.

@mattbrictson mattbrictson added the 🐛 Bug Fix Fixes a bug label Oct 29, 2024
@mattbrictson mattbrictson changed the title Fix bug where prerelease rails new version was erroneously used Fix bug where prerelease rails new version was used instead of the intended release version Oct 29, 2024
@mattbrictson mattbrictson changed the title Fix bug where prerelease rails new version was used instead of the intended release version Fix bug where 8.0.0.rc1 rails new version was used instead of the intended 7.2.1 Oct 29, 2024
@mattbrictson mattbrictson marked this pull request as ready for review October 29, 2024 20:16
@mattbrictson mattbrictson changed the title Fix bug where 8.0.0.rc1 rails new version was used instead of the intended 7.2.1 Fix bug where rails new used 8.0.0.rc1 instead of the intended 7.2.1 Oct 29, 2024
@mattbrictson mattbrictson merged commit e1565cc into main Oct 29, 2024
16 checks passed
@mattbrictson mattbrictson deleted the use-correct-rails-ver branch October 29, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant