Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Werror, fix LDFLAGS, silence rpm error in Makefile #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chewi
Copy link

@chewi chewi commented Jun 12, 2024

Distributions don't like -Werror because it prevents end users from building the software using newer compilers that may raise warnings you don't know about yet. This is particularly bad for source-based distributions like Gentoo.

Some LDFLAGS need to come before the inputs in order to be effective.

Silence the error when the rpm command doesn't exist and add a fallback because the error can trigger QA warnings in non-RPM distros.

chewi added 3 commits June 12, 2024 22:50
Distributions don't like -Werror because it prevents end users from
building the software using newer compilers that may raise warnings you
don't know about yet. This is particularly bad for source-based
distributions like Gentoo.
Some flags need to come before the inputs in order to be effective.
The error can trigger QA warnings in non-RPM distros.
@chewi chewi changed the title Remove -Werror and fix LDFLAGS in Makefile Remove -Werror, fix LDFLAGS, silence rpm error in Makefile Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant