chore: enable nix cargo vendor #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add Cargo.lock - add riscv_common to workspace - add the missing workspace members. - remove workspace.edition from `examples/experiments/Cargo.toml` which is somehow not liked by `cargo metadata` This enables the nix cargo vendor mechanism to pull in this git repo as a dependency. Signed-off-by: Harald Hoyer <[email protected]>
antoniolocascio
approved these changes
Jun 6, 2025
haraldh
added a commit
to matter-labs/zksync-os
that referenced
this pull request
Jun 6, 2025
- added a `Cargo.lock` for the `zksync_os` subdirectory. This reduces problems with the nix rust dependency fetcher drastically. - rerouted the zksync-airbender dependency to the PR version matter-labs/zksync-airbender#37 which fixed several issues with the nix rust dependency fetcher. Another fix would be a release of `riscv_common` on crates.io. - modified `.cargo/config.toml` to strip build environment paths, which are replaced by the nix build script to ensure reproducibility. See `nix/README.md` how to build. Signed-off-by: Harald Hoyer <[email protected]>
6 tasks
|
Do we really need to add Cargo.lock in the main place? (as in theory this is a library, right?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
examples/experiments/Cargo.tomlwhich is somehow not liked bycargo metadataWhy ❔
This enables the nix cargo vendor mechanism to pull in this git repo as a dependency.
Is this a breaking change?
Checklist