-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: precompiles & v28 #3728
DRAFT: precompiles & v28 #3728
Conversation
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
@@ -107,9 +107,10 @@ impl<C: ContractsKind> MultiVmBaseSystemContracts<C> { | |||
ProtocolVersionId::Version25 => &self.vm_protocol_defense, | |||
ProtocolVersionId::Version26 => &self.gateway, | |||
ProtocolVersionId::Version27 => &self.vm_evm_emulator, | |||
|
|||
// Speculative base system contracts for the next protocol version to be used in the upgrade integration test etc. | |||
// TODO: use v28 contracts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: should be done when contracts commit is finalized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT, GEOMETRY_CONFIG
wasn't changed for pre-v28 circuits except for cycles_per_log_demuxer
, it went from 58750 to 58125. @mm-zk is that expected, was circuit changed indeed? Anyway, it's ok to just update GEOMETRY_CONFIG
in place since value decreased, so seal criterion is stricter now.
…b612f12 chore: Update generated Prover FRI GPU setup-data keys from branch mmzk_0318_v28_precomiples
feat: v28 multivm
Detected VM performance changes
⚠ Detected differing instruction counts
Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it to run out of gas at a different time. |
What ❔
Preparation for v28 and precompiles