Skip to content

Conversation

@slowli
Copy link
Contributor

@slowli slowli commented Mar 25, 2025

What ❔

  • Stores VM dumps in the core object store at least for local and CI runs.
  • Fails integration tests if VM divergences are observed in API.

Why ❔

Ensures that there are no unexpected VM divergences (previously, there were some because they were only logged).

Is this a breaking change?

  • Yes
  • No

Operational changes

VM dumps are stored in the object store specified in core_object_store in the general config.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@slowli slowli force-pushed the aov-pla-1102-store-vm-dumps-for-diverging-executions-in-api-server branch 2 times, most recently from ad5ca0a to e45e631 Compare March 27, 2025 07:59
@slowli slowli marked this pull request as ready for review March 27, 2025 10:12
@slowli slowli requested a review from a team as a code owner March 27, 2025 10:12
@slowli
Copy link
Contributor Author

slowli commented Mar 27, 2025

Tested manually by introducing an error to the fast VM wrapper in multivm. Integration tests failed in CI, and VM dumps were added to the generated file artifacts as expected.

perekopskiy
perekopskiy previously approved these changes Apr 1, 2025
@slowli slowli added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 3835d09 Apr 15, 2025
37 checks passed
@slowli slowli deleted the aov-pla-1102-store-vm-dumps-for-diverging-executions-in-api-server branch April 15, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants