fix: prevent uncommitted chain migrating from gw

[zkzoomer]

What ❔

Chains migrating from gateway must not have uncommitted batches, as these can contain interop roots. If a chain tries to commit a batch with interop roots on the L1 the commit transaction would fail. The idea then is to make it so that during migration from gateway 1) interop roots stop being added to the database 2) all interop roots are processed 3) all batches containing interop roots get committed.

Why ❔

Is this a breaking change?

• Yes
• No

Operational changes

Checklist

• PR title corresponds to the body of PR (we generate changelog entries from PRs).
• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• Code has been formatted via zkstack dev fmt and zkstack dev lint.

[perekopskiy]

Was this code tested?

[zkzoomer]

Was this code tested?

@perekopskiy It was tested locally: migrating back from gateway takes longer because of these additional checks. It doesn't run on CI as that step it was accidentally removed recently as part of #4255

[Deniallugo]

Unfortunately it won't work fully, just because for not sealed batch, we don't have l1 batch attached to miniblocks. so for non sealed batch but with interop roots, this check will fail

[zkzoomer]

If the batch is not sealed then get_latest_processed_interop_root_l1_batch_number should return None -> the function is_waiting_for_batches_with_interop_roots_to_be_committed will return true, which is the intended effect as batches with blocks containing interop roots have not yet been committed. See:

zksync-era/core/node/eth_sender/src/eth_tx_aggregator.rs

Lines 1160 to 1171 in 98c960d

	async fn is_waiting_for_batches_with_interop_roots_to_be_committed(
	&self,
	storage: &mut Connection<'_, Core>,
	) -> Result<bool, EthSenderError> {
	let latest_processed_l1_batch_number = storage
	.interop_root_dal()
	.get_latest_processed_interop_root_l1_batch_number()
	.await?;
	if latest_processed_l1_batch_number.is_none() {
	return Ok(true);
	}