Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected workspaces rewrites & updates for Beta release #7575

Merged
merged 14 commits into from
Nov 14, 2024

Conversation

@cwarnermm cwarnermm added the Work In Progress Not yet ready for review label Nov 7, 2024
@cwarnermm cwarnermm added this to the v10.2.0 milestone Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Newest code from mattermost has been published to preview environment for Git SHA ec3c968

@cwarnermm cwarnermm removed the Work In Progress Not yet ready for review label Nov 8, 2024
@cwarnermm
Copy link
Member Author

cwarnermm commented Nov 8, 2024

@mgdelacroix - Please confirm whether the remote clusters configuration setting should remain documented as-is via Experimental, or if it needs changes for connected workspaces.

Also, please confirm whether any of the connected workspace configuration settings should be added to the Telemetry page.

@cwarnermm cwarnermm added the 1: Dev Review Requires review by a core commiter label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Newest code from mattermost has been published to preview environment for Git SHA 46144f9

source/conf.py Outdated Show resolved Hide resolved
source/conf.py Outdated Show resolved Hide resolved
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 70818b1

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 1b38c80

Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Added a couple of change proposals and questions

source/configure/reporting-configuration-settings.rst Outdated Show resolved Hide resolved
source/configure/reporting-configuration-settings.rst Outdated Show resolved Hide resolved
source/configure/site-configuration-settings.rst Outdated Show resolved Hide resolved
source/configure/site-configuration-settings.rst Outdated Show resolved Hide resolved
source/onboard/connected-workspaces.rst Show resolved Hide resolved
source/configure/site-configuration-settings.rst Outdated Show resolved Hide resolved
@mgdelacroix
Copy link
Member

mgdelacroix commented Nov 13, 2024

Please confirm whether the remote clusters configuration setting should remain documented as-is via Experimental, or if it needs changes for connected workspaces.

We're maintaining those configuration parameters marked as deprecated, and they will have no effect beyond the initial automated migration to ConnectedWorkspaces the first time v10.2 runs, so I think we should mark them as deprecated in the experimental section and point to the new ones.

Also, please confirm whether any of the connected workspace configuration settings should be added to the Telemetry page.

Yes, all ConnectedWorkspaces properties have been added to the telemetry payload with the following format:

{
  "config_connected_workspaces": {
    "enable_shared_channels": val,
    "enable_remote_cluster_service": val,
    "disable_shared_channels_status_sync": val,
    "max_posts_per_sync": val
  }
}

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 9cf5844

@cwarnermm
Copy link
Member Author

Thank you, @mgdelacroix, for your excellent review and input. I've incorporated your feedback in my last couple of commits. This docs PR is ready for your approval.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 4ffce02

@cwarnermm cwarnermm merged commit 8915cf7 into v10.2-documentation Nov 14, 2024
4 checks passed
@cwarnermm cwarnermm deleted the connected-workspaces-beta branch November 14, 2024 16:23
amyblais added a commit that referenced this pull request Nov 15, 2024
* Update conf.py

* Re-adding missing image

* Removed Cloud deploy badge (#7513)

* Removed full screen mode on Linux (#7514)

* Replaced Calls plugin prefs with general page (#7516)

* Updated End Call for All to server v10.2 (#7517)

* Updated list of exported data (#7518)

* Pinned icon hidden when no messages pinned in channel (#7519)

* Pinned icon hidden when no messages pinned in channel

* Update source/collaborate/save-pin-messages.rst

* Added release details for MobileExternalBrowser (#7520)

* Clarified AllowOtherServers functionality (#7556)

* Clarified that LDAP users can't be deactivated via MM (#7561)

* Added menu option to access logs (#7521)

* Added EnableAPIPostDeletion config setting & mmctl command (#7563)

* Added PG FAQs based on customer input (#7586)

* Added env var developer mode setting (#7515)

* Added env var developer mode setting

* Update source/configure/environment-configuration-settings.rst

* Update source/configure/environment-configuration-settings.rst

* Editing pass updates

* Added upgrade & maintenance guidance for plugins (#7554)

* Added upgrade & maintenance guidance for plugins

* Update source/integrate/github-interoperability.rst

Co-authored-by: Maria A Nunez <[email protected]>

* Update source/guides/integrate-and-extend.rst

* Incorporated reviewer feedback

---------

Co-authored-by: Maria A Nunez <[email protected]>

* Config in database corrections (#7559)

* Reordered process

* Elevated HA guidance

* Incorporated reviewer feedback

* Updated language & added docs link (#7582)

* Docs listening: Clarified the path config for the ES certificate (#7583)

* Clarified the path config for the ES certificate

* Update source/configure/environment-configuration-settings.rst

* Added mobile workflow (#7584)

* Added Playbooks FAQs based on customer feedback (#7585)

* Docs listening: Added custom emoji screenshot (#7587)

* Added custom emoji screenshot

* Update source/collaborate/react-with-emojis-gifs.rst

* v10.2 Changelog (#7497)

* Update mattermost-server-releases.md

* Update download-latest-tarball.rst

* Update deprecated-features.rst

* Update mattermost-server-releases.md

* Update release-policy.md

* Update mattermost-mobile-releases.md

* Update mattermost-desktop-releases.md

* Update mattermost-v10-changelog.md

* Update mattermost-v9-changelog.md

* Update version-archive.rst

* Update important-upgrade-notes.rst

* Update prepare-to-upgrade-mattermost.rst

* Update open-source-components.rst

* Update mattermost-v10-changelog.md

* Update important-upgrade-notes.rst

* Update deprecated-features.rst

* Update mattermost-server-releases.md

* Update release-policy.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Apply suggestions from code review

Co-authored-by: Doug Lauder <[email protected]>

* Update source/about/mattermost-v10-changelog.md

Co-authored-by: Doug Lauder <[email protected]>

* Apply suggestions from code review

Co-authored-by: Doug Lauder <[email protected]>

* Update source/about/mattermost-v10-changelog.md

Co-authored-by: Carrie Warner (Mattermost) <[email protected]>

* Update source/about/mattermost-v10-changelog.md

Co-authored-by: Christopher Poile <[email protected]>

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

* Update mattermost-v10-changelog.md

---------

Co-authored-by: Doug Lauder <[email protected]>
Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
Co-authored-by: Christopher Poile <[email protected]>

* Added guidance on using team-URL over display name (#7588)

* Replaced YES with standard green checkmarks (#7589)

* Docs listening: Elevate comply and secure topics to align with scale (#7592)

* Elevated secure & comply to align with scale

* Added breadcrumb links to related topics

* Clarified that admins can perform any actions on a system (#7596)

* Fixed build warning

* Connected workspaces rewrites & updates for Beta release (#7575)

* Connected workspaces rewrites & updates for Beta release

* Added config settings, page redirects

* Update source/conf.py

* Update source/configure/reporting-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <[email protected]>

* Update source/configure/reporting-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <[email protected]>

* Update source/configure/site-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <[email protected]>

* Update source/configure/site-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <[email protected]>

* Update source/onboard/connected-workspaces.rst

Co-authored-by: Miguel de la Cruz <[email protected]>

* Update source/configure/site-configuration-settings.rst

Co-authored-by: Miguel de la Cruz <[email protected]>

* Added telemetry and deprecated remote cluster config

* Updated default value

---------

Co-authored-by: Miguel de la Cruz <[email protected]>

* Link check fixes

* Added best practice recommendations re: attributes & identifiers (#7562)

---------

Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
Co-authored-by: Maria A Nunez <[email protected]>
Co-authored-by: Doug Lauder <[email protected]>
Co-authored-by: Christopher Poile <[email protected]>
Co-authored-by: Miguel de la Cruz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Dev Review Requires review by a core commiter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants